Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not wroking properly #1

Open
BuSHari opened this issue Oct 28, 2017 · 2 comments
Open

Not wroking properly #1

BuSHari opened this issue Oct 28, 2017 · 2 comments

Comments

@BuSHari
Copy link

BuSHari commented Oct 28, 2017

Love your script, this is exactly what i need, but there are some issues that i hope that you can correct them.

  • Can you make it that it will work on both ways? (reverse & unreverse)
  • when i try to use your script as is it make a new row with the punctuation

Here some examples (attached)

UnReverse Punctuation.zip
Reverse Punctuation.zip

@asafs
Copy link
Owner

asafs commented May 18, 2018

Hi,
Sorry for the very long delay in the response.
I made a very small fix with the encoding, and was able to convert your file correctly (attached).
Not sure it fixed your issue, but please try again.

About the unreverse, i tested it and it should work as is. let me know if it doesn't work for you after the fix.

Annabelle 2 Creation (2017).REV.srt.zip

@BuSHari
Copy link
Author

BuSHari commented May 23, 2018

Hi thanks for the fix but i'm getting sn error now:

BuSHari@DiskStation:~/reverse-subtitles$ python rev.py "Annabelle.heb.forced.srt"
Found 1 files. Starting to convert
Converting File: Annabelle.heb.forced.srt
Traceback (most recent call last):
  File "rev.py", line 101, in <module>
    Main()
  File "rev.py", line 91, in Main
    ReversePuctuation(file, newFile)
  File "rev.py", line 40, in ReversePuctuation
    f = open(file, 'r', encoding="Windows-1255")
TypeError: 'encoding' is an invalid keyword argument for this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants