New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Angular6 #13

Open

rene8a opened this issue Dec 5, 2018 · 1 comment

rene8a commented Dec 5, 2018

According to the code implemented for that directive: https://github.com/arup-banerjee/ngx-draggable-widget/blob/master/src/directives/NgWidgetContainer.ts#L13
It is using the old host property to listen the events from the host, but it should be using @HostBindings or @HostListeners.
The expected behavior for this property it is to set the margin from the right to left to be able to resize the widget. You can see in the following lines: https://github.com/arup-banerjee/ngx-draggable-widget/blob/master/src/directives/NgWidget.ts#L271
Because of that the border-size is not affecting margin.
That it is the only property that actually it is not working according what we have tested on a Angular 6 application

KAMAELUA commented Feb 6, 2019

Hi, I trying to update that packedge to Angular6. You can check my repository if you want on KAMAELUA/ngx-draggable-widget or as NPM packadge ngx-draggable-widget-kama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment