Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent installing with mrt #150

Open
aramk opened this issue Dec 13, 2014 · 3 comments
Open

Prevent installing with mrt #150

aramk opened this issue Dec 13, 2014 · 3 comments

Comments

@aramk
Copy link

aramk commented Dec 13, 2014

I tend to develop meteor packages locally by creating symbolic from the packages directory. When running mrt, these are removed, but since I use Meteor's own package manager, there's no need to run mrt anyway. The issue is that Laika always runs Meteor through mrt, removing these symlinks. It would be nice to have a no-mrt option to avoid this and run meteor directly.

@apendua
Copy link
Collaborator

apendua commented Dec 13, 2014

I think it depends on the existence of smart.json file in your project root
directory. Can you try removing it and see what happens? If it does not
help we can surely implement the solution your talking about.

W dniu sobota, 13 grudnia 2014 Aram Kocharyan [email protected]
napisał(a):

I tend to develop meteor packages locally by creating symbolic from the
packages directory. When running mrt, these are removed, but since I use
Meteor's own package manager, there's no need to run mrt anyway. The
issue is that Laika always runs Meteor through mrt, removing these
symlinks. It would be nice to have a no-mrt option to avoid this and run
meteor directly.


Reply to this email directly or view it on GitHub
#150.

@aramk
Copy link
Author

aramk commented Dec 14, 2014

Hi @apendua. Removing smart.json works as a temporary solution as long as it's added back after running the tests. It still has the purpose of specifying the external, unpublished packages (most of them forks) used in the project, so removing them permanently isn't an option. I suspect replacing the invocation of mrt to meteor within laika if an option is provided would work well.

@apendua
Copy link
Collaborator

apendua commented Dec 14, 2014

@aramk I agree. Can you implement this fix and submit a PR? I would also suggest looking into another testing solution which I am currently working on:
https://github.com/anticoders/gagarin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants