Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial QA for new search bar #2043

Closed
3 of 10 tasks
jonallured opened this issue Feb 20, 2019 · 3 comments
Closed
3 of 10 tasks

Initial QA for new search bar #2043

jonallured opened this issue Feb 20, 2019 · 3 comments

Comments

@jonallured
Copy link
Member

jonallured commented Feb 20, 2019

  • Fix positioning in force - after Update SearchBar to better match comps #2042 gets merged
  • Style for medium/small breakpoints (after fixing positioning ^^^, and after feedback from Jeffrey)
  • The "return" icon is missing on active suggestion
    • There is an issue for palette to add this icon (and many others). As I noted in that issue, none of the icons have semantic <title> tags, so they may not be ready for creation yet.
  • Decorate input with form so that non-js searches will submit correctly
  • Cross-browser testing!
  • Verify keyboard usability
  • Maybe set a permanent height of the box, so it doesn't dance around?
  • Maybe set explicit width/height of preview grid item image containers so that they don't dance around when images are loading?
  • The loading spinner seems off-center in the preview pane.
  • If I click on the items in the previews, the search box closes but I don't go anywhere!

Notes:

  • When choosing a suggestion, the experience seems a little strange. The term is removed from the input and the suggestions disappear before the URL changes or the new page is loaded.
  • Investigate what happens when you move breakpoints - it appears that there are actually two searches ATM!
    • Sounds like Jeffery will explore this more
  • The SearchBar seems to snap in about a second after the page shows up
@jonallured
Copy link
Member Author

Oops, closing in favor of the list over on #2042 😝

@pepopowitz
Copy link
Contributor

We decided to extract a bunch of stuff from #2042, so I'm reopening & updating the list of remaining issues!

@pepopowitz pepopowitz reopened this Feb 21, 2019
@pepopowitz
Copy link
Contributor

Closing again because we moved these all to JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants