Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Elements / Pagination / Pagination #622

Open
mzikherman opened this issue Dec 19, 2019 · 0 comments
Open

[Update] Elements / Pagination / Pagination #622

mzikherman opened this issue Dec 19, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@mzikherman
Copy link
Contributor

Right now, this component renders page numbers, and Prev/Next. These are implemented as either div elements with custom click handlers (page numbers), or empty anchor tags without any href set, also with a custom click handler (Prev/Next).

This is sort of semantically incorrect, and so I'm labeling it a bug. All of these should just be anchor tags with the proper href set. Any custom behavior designed to intercept/route links differently is happening outside of Palette.

@mzikherman mzikherman added the bug Something isn't working label Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant