Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old flags #90

Open
pvinis opened this issue May 17, 2021 · 0 comments
Open

Remove old flags #90

pvinis opened this issue May 17, 2021 · 0 comments

Comments

@pvinis
Copy link
Contributor

pvinis commented May 17, 2021

We have some comments like old flag or remove once few or no users are on version X.Y.Z in Echo.json5.

We should take a look at https://artsy.looker.com/explore/frontend_analytics/eigen_tracks?qid=SZXeeacYh6Hq2CnE9ooGDl&origin_space=712&toggle=fil,vis every few months, and if few or no users are on that version, we could then remove the flag (if it says remove once..) or remove the old flag comment and treat the flag as a regular echo flag from then on.

Some context, #87, #89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pvinis