Enhancement in the tools/makem.js script and other fixes #96
Conversation
|
@nicolocarpignoli I would add also the |
|
I simply tested adding I think we should also improve the nft examples @ThorstenBux, should we present only the WASM version as you did in your https://github.com/ThorstenBux/ar-magazine/blob/master/src/threejs_wasm_worker.js ? if (navigator.mediaDevices && navigator.mediaDevices.getUserMedia) {
var hint = {
audio: false,
video: true
};
if (window.innerWidth < 800) {
hint = {
audio: false,
video: {
width: { ideal: 480 },
height: { ideal: 640 },
facingMode:
{ exact:
"environment"
}
},
};
}
navigator.mediaDevices.getUserMedia(hint).then(function(stream) {
video.srcObject = stream;
video.addEventListener("loadedmetadata", function() {
video.play();
start(
container,
markers["pinball"],
video,
video.videoWidth,
video.videoHeight,
canvas,
function() {
statsMain.update();
},
function() {
statsWorker.update();
},
null
);
});
});
}became an external script and ypu need only: // inside threejs_main_worker.html before end of </script></body>
<script src="nftLoader.js"></script>
nftLoader(markers, 640, 480, canvas, video, statsMain, statsWorker); |
|
Testing code in my other repository here https://github.com/kalwalt/kalwalt-interactivity-AR/blob/master/nft/nftLoader.js used in this html example, basically you can simply: <body>
// other html code here
<script>
/**
* APP / ELEMENTS
*/
var container = document.getElementById("app");
var video = document.getElementById("video");
var canvas = document.getElementById("canvas");
nftLoader(container, video, 480, 640, canvas, "pinball", true);
</script>
</body> |
|
@ThorstenBux in some machine you can experience |
|
I would add it yes. I recall on my iPhone 6s that it breaks without -s ALLOW_MEMORY_GROTH=1 |
i never experienced this, probably because i have tested only on Android, @nicolocarpignoli instead experienced this and we added in the version embedded for AR.js. I will add for sure. |
|
Have you experienced this issue while trying one of my examples here as you said in this kalwalt#42 (comment) ? |
|
No I haven't however I'm not sure with which device I tested that. |
- switched to camera_para.dat - simplyfied code for Fullscreen - better end loading
|
@ThorstenBux i added
|
|
Thank you. I'll check why the build isn't working and merge then. |
yes, bitrise is failing for some time, I forgot to tell you. |
|
@ThorstenBux bitrise failing because the github-release don't find some of the input variables: |
|
Some bug there. A PR should never push a release. I'm on it |
This PR add these features:
description of the new script feature:
to build the whole libs run the build command with:
npm run build-localwith Docker ( !! recommended !! ):
docker exec emscripten npm run build-localafter this libar.bc is build and if you have done some changes in the code, but not in artoolkit5, you don't need to build libar.bc again so run:
npm run build-local-no-libarwith Docker ( !! recommended !! ):
docker exec emscripten npm run build-local-no-libarIn this way the build process will take about in half the time.
Related PR kalwalt#45 issue kalwalt#44