Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangles and squares not appearing in the plots #36

Open
Paulbagourd opened this issue Oct 12, 2023 · 2 comments
Open

Triangles and squares not appearing in the plots #36

Paulbagourd opened this issue Oct 12, 2023 · 2 comments

Comments

@Paulbagourd
Copy link

Hello,

I have installed Pytheus on my computer and ran the exact config file examples (copy-paste config_cnot22_sp.json, etc...) given in the repository, however when I plot the best result I never obtain any squares or triangles, even though there should be auxiliary qubits and single photon sources. The graphs are similar to the pdf ones of the repository but with only round vertices.

Would you know what's the issue? Do I have to get another version or specify something else in the configuration?

Thank you,
Paul

@cruizgo
Copy link
Collaborator

cruizgo commented Oct 17, 2023

We are currently working on an update of certain tools, including the plotter. Therefore it might take us a bit to fix this issue.

I want to stress that even if only round vertices are shown in the plot, that doesn't mean that they are standard detectors:

  • A round vertex with a single color going in is acting as an ancilla. Since the photon state is not entangled in any way with the others.
  • The single photon sources are trickier to pinpoint. They are bicolored edges, with the blue half (dimension 0) connecting the input node and the second color connected to the detector or output. No edge can connect 2 single photon sources, since those vertices are not detectors.

We will check the error in more detail the next days. In the meantime I hope this allows you to keep working with our framework and checking whether the provided solutions are correct.

Thank you for your patience!

@Paulbagourd
Copy link
Author

Hello,

Indeed the graphplot.py module that I installed using "pip install pytheusQ" does not contain the specific functions for triangles and squares.

I tried to directly install the branch from github using "pip install git+https://github.com/artificial-scientist-lab/PyTheus.git@main" but then I was getting an IndexError because it seems the keys of the graph dictionnary are strings, not tuples.

Modifying the graph by preconverting strings to tuples at each "graph" call in graphplot.py draws the plot but still without triangles and squares so I guess there is more to do.

Please let me know when the update is ready. Thank you for your response and for the temporary fix,

Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants