Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: storing thumbnails on disk #200

Open
Rentib opened this issue Oct 18, 2024 · 1 comment · May be fixed by #201
Open

feat: storing thumbnails on disk #200

Rentib opened this issue Oct 18, 2024 · 1 comment · May be fixed by #201
Labels
feature

Comments

@Rentib
Copy link

Rentib commented Oct 18, 2024 •
edited
Loading

I don't know if this is completely outside the scope of the project, but I did a quick and dirty hack that caches thumbnails on disk similarly to how nsxiv does it. I ran some benchmarks and it saves 10 to 20 ms per image. The gallery still takes a very long time to load but the difference is there. If this is something that might get merged, I'd be happy to make a PR.
@artemsen
Copy link
Owner

Sure! Make your PR and we'll discuss.

@Rentib Rentib linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: storing thumbnails on disk Rentib/swayimg
2 participants
@artemsen @Rentib