From 23d1e07d5dea8d5c8c5cdb34885e6b4a265308d5 Mon Sep 17 00:00:00 2001 From: Joel Dunham Date: Wed, 29 Nov 2017 13:49:12 -0800 Subject: [PATCH] Fix `Package.should_have_pointer_file()` Before this, this method was incorrectly returning `True` if the package was an AIP (or AIC) even if it was not a file (i.e., was not compressed). --- storage_service/locations/models/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage_service/locations/models/package.py b/storage_service/locations/models/package.py index ff7e75a30..034b1eba4 100644 --- a/storage_service/locations/models/package.py +++ b/storage_service/locations/models/package.py @@ -561,7 +561,7 @@ def should_have_pointer_file(self, package_full_path=None, package_type = self.package_type isfile = os.path.isfile(package_full_path) isaip = package_type in (Package.AIP, Package.AIC) - ret = isfile or isaip + ret = isfile and isaip if not ret: if not isfile: LOGGER.info('Package should not have a pointer file because %s'