-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apt-utils.sh: get base-files package version from GHA #7473
Conversation
f80de44
to
346d625
Compare
d9c57e3
to
16f820d
Compare
Cool!
Why not include this into the armbian/build repo instead of using a separate repo just for the script? Build could just run the parser on the fly and put the resulting json in the cache directory, what do you think? |
The parser script is still querying pkg info from pacakges.debian.org or packages.ubuntu.com, if the site is down, build would still fall if there is no local cache. |
Excellent, @amazingfate -- super thanks. A few nits: I've reviewed https://github.com/amazingfate/deb-files-parser -- looks fine, only suggestions there would be
And to say the truth I can't follow where |
I expanded this to put here some other JSON files that are in use. And, top level org pages has this (sub)domain: (normally armbian.github.io) |
Nice this makes sense. I will send PRs down there in the future, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cherry-picked, built a large train, published to repo, everything seems to work fine.
16f820d
to
583abf1
Compare
Description
I have written a python script running in Github workflow: https://github.com/amazingfate/deb-files-parser, which will generate all versions of
base-files
from debian and ubuntu in a json file: https://github.com/amazingfate/deb-files-parser/blob/master/base-files.json, and now we can get rid of the unstable packages.debian.org or packages.ubuntu.com.If this change is fine, we can move the repo
amazingfate/deb-files-parser
to armbian.Deprecating: #7286
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh BOARD=rock-5b BRANCH=vendor BUILD_MINIMAL=yes DEB_COMPRESS=xz DOWNLOAD_MIRROR=china KERNEL_CONFIGURE=no RELEASE=jammy GITHUB_MIRROR=ghproxy KERNEL_GIT=shallow BUILD_DESKTOP=no ENABLE_EXTENSIONS=mesa-vpu DEBUG=yes
. Build log:Checklist:
Please delete options that are not relevant.