Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Sidebar does not close on iOS since 7.3.0 #154

Open
acuntex opened this issue Aug 23, 2018 · 2 comments
Open

Sidebar does not close on iOS since 7.3.0 #154

acuntex opened this issue Aug 23, 2018 · 2 comments
Labels

Comments

@acuntex
Copy link

acuntex commented Aug 23, 2018

We recently upgraded to Angular 6 and also upgraded ng-sidebar.

We noticed that the sidebar does not close and is not clickable at all on iOS (iPhone).

After trying out older versions, we figured out that the behavior started in V7.3.0, so it must be one of those changes:
v7.2.1...v7.3.0

Here is the version with 7.2.1:
www.neobirdgames.com
Here is the version with 7.3.0 (would be the same with 8.0.0):
beta.neobirdgames.com

The code looks like this:

<ng-sidebar-container #sideBarContainer [ngClass]="{'ng-content-padding-fix': !appService.gameInfo}">
  <ng-sidebar #sideBar *ngIf="isHiddenLayout" position="right" mode="over" class="platformMenu mobile-side-bar" (onClosed)="menuClosed()" [(opened)]="sideBarService.opened" autoFocus="false" [showBackdrop]="true" [closeOnClickBackdrop]="true">
    <platform-menu-button (onSideBarSlide)="onSideBarSlide($event)"></platform-menu-button>
    <div class="platform-content" (swiperight)="onSwipeRightMobile()">
      <platform-content></platform-content>
    </div>
  </ng-sidebar>
...
</ng-sidebar-container>

I honestly cannot imagine any logical explanation how the changes made in 7.3.0 could be responsible for a bug, but then again: It's only on iOS Safari, so logic is probably not the best tool ;-)

@arkon arkon added the bug label Aug 30, 2018
@arkon
Copy link
Owner

arkon commented Aug 30, 2018

I honestly can't see why any of those changes would affect it either...

@acuntex
Copy link
Author

acuntex commented Sep 3, 2018

Since code as been moved to the end of the method, might there be a chance, that this could be the cause (like more changes on iOS or some race condition)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants