Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Support of validate_lldp key in structured config #4777

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Fix(eos_designs): Support of validate_lldp key in structured config #4777

wants to merge 2 commits into from

Conversation

bjmeuer
Copy link
Contributor

@bjmeuer bjmeuer commented Dec 3, 2024

Change Summary

write the key "validate_lldp" into the structured config.

Related Issue(s)

Fixes #4776

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

servers:
  - name: Server
    adapters:
      - endpoint_ports: [Eth5, Eth6]
        switch_ports: [Ethernet47, Ethernet47]
        switches: [de-dcb-a-dcn-cs-010-071, de-dcb-a-dcn-cs-010-072]
        profile: CLIENT-Netz-101-Trunk
        port_channel:
          description: PortChannel_to_server
          mode: active
        validate_lldp: false

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@bjmeuer bjmeuer requested review from a team as code owners December 3, 2024 11:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4777
# Activate the virtual environment
source test-avd-pr-4777/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/bjmeuer/avd.git@issue4776_validate_lldp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/bjmeuer/avd.git#/ansible_collections/arista/avd/,issue4776_validate_lldp --force
# Optional: Install AVD examples
cd test-avd-pr-4777
ansible-playbook arista.avd.install_examples

gmuloc
gmuloc reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh .. thanks for catching this @bjmeuer - could we add a test on some adapter in the eos_validate_state molecule scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

At least 2 approving reviews are required to merge this pull request.

Assignees

@bjmeuer bjmeuer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix(eos_designs): Support of validate_lldp key in structured config
3 participants
@bjmeuer @gmuloc @ClausHolbechArista