Feat(eos_designs): Add revised schema to support L3 Port-Channel interfaces #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4752
# Activate the virtual environment
source test-avd-pr-4752/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@samplePRBranch#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,samplePRBranch --force
# Optional: Install AVD examples
cd test-avd-pr-4752
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
github-actions
bot
added
role: eos_cli_config_gen
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
2f1a500
to
d3086d9
Compare
github-actions
bot
removed
role: eos_cli_config_gen
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
d3086d9
to
7d8c276
Compare
...on-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type_l3_port_channels.schema.yml
Show resolved
Hide resolved
...on-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type_l3_port_channels.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
a8fa6b9
to
1d61e17
Compare
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
2e10ead
to
f35199a
Compare
github-actions
bot
added
the
state: CI Updated
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
cfae876
to
fccd4c8
Compare
XiangyiGuo
reviewed
Dec 3, 2024
| @@ -105,7 +105,9 @@ def underlay_port_channel_interface(self, data: InterfaceDescriptionData) -> str | |||
| - mpls_overlay_role | |||
| - mpls_lsr | |||
| - overlay_routing_protocol | |||
| - type. | |||
| - type | |||
| - wan_carrier | |||
There was a problem hiding this comment.
Do we allow user to configure carrier and circuit id for L3 interfaces as well or only for port channel interfaces?
There was a problem hiding this comment.
Yes, we allow user to configure these attributes for L3 interfaces as well.
Most of the schema attributes for L3 Port-Channels overlap with L3 Interfaces.
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
fccd4c8
to
b8175d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Revised schema to support L3 Port-Channel interfaces
Primary use-case is to allow such interfaces as wan-facing interfaces.
Related Issue(s)
Fixes #4695
Component(s) name
arista.avd.eos_designsProposed changes
How to test
This change captures the first step towards having a schema within
eos_designsto represent L3 port-channel interface.
The underlying logic to support the newly added schema and tests would be worked upon next.
Checklist
User Checklist
Repository Checklist