Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendered instants should be sandboxed in an iframe #18

Open
jakub-g opened this issue Dec 11, 2014 · 0 comments
Open

Rendered instants should be sandboxed in an iframe #18

jakub-g opened this issue Dec 11, 2014 · 0 comments
Labels
enhancement

Comments

@jakub-g
Copy link
Collaborator

jakub-g commented Dec 11, 2014

When you look at how jsfiddle, jsbin et al. works they all have <iframe> for sandboxing rendered content. We don't have it, just render things in a <div> and then it causes unexpected behaviors, like <BODY> referencing the body of the whole application, not the body of the instant's viewport.

Take a look at this sample
http://instant.ariatemplates.com/anonymous/656ad51fd658295887d8/3e1f96

it's just a copy-paste of a usermanual entry
http://ariatemplates.com/usermanual/next/processingindicator

Since BODY is the IA app, the "whole" page overlay behaves quite unexpectedly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakub-g