Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler should throw an exception when compilation fails #61

Open
PK1A opened this issue Feb 10, 2014 · 1 comment
Open

Compiler should throw an exception when compilation fails #61

PK1A opened this issue Feb 10, 2014 · 1 comment

Comments

@PK1A
Copy link
Contributor

PK1A commented Feb 10, 2014

Currently compiler will generate output even if compilation fails. While it is true that it also sets a flag indicating if a compilation failed or not, it makes working with the compiler API harder than it needs to be. For example, while working on a Grunt / gulp plugin, we shouldn't need to generate a file that would output errors in a browser, we should simply break the compilation (fail fast). We can still generate client-side files in the express integration, though.

My proposal here is the following one - let's remove the error-reporting content generation from the compiler and let's move it to a separate class that could be plugged on top of the compiler.

@divdavem
Copy link
Member

👍

For info, some time ago, I started doing this change on the compilerErrorHandling branch on my fork: see here. I have not taken the time to finish it yet, but I think it is important to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants