Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvement suggestions #12

Open
susant123 opened this issue Dec 5, 2013 · 0 comments
Open

Code improvement suggestions #12

susant123 opened this issue Dec 5, 2013 · 0 comments

Comments

@susant123
Copy link

I was going through few Java files. Might be you can consider below suggestions.

  • Backend.java
    1. Final static variable command can be renamed to COMMAND
    2. Few variables like gson can be declared final I suppose as it is initialized in the constructor
    3. How about using an if instead of switch as it has only one case (in postJson())
  • Activator.java
    1. Do we need to write default constructor?
  • POCDocument.java
    1. How about changing private GUID to guid as its a not a constant?
  • POCDocumentPartitioner.java
    1. How about changing types to TYPES as it is final static?
  • POCDocumentProvider.java
    1. How about changing mode to MODE as it is final static?
  • POCTokenScanner.java
    1. Do we really need the default constructor?

I am not sure if code formatter is being used. If not will request to add a standard code formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants