Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Archived Workflows merge to the Upgrading Notes #13371

Merged
merged 1 commit into from
Jul 22, 2024
Merged

docs: add Archived Workflows merge to the Upgrading Notes #13371

merged 1 commit into from
Jul 22, 2024

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Jul 21, 2024 •
edited
Loading

Addresses #12545, #13126 (reply in thread), #13356, etc

Motivation

  • The Archived Workflows UI merge (feat: Unified workflows list UI and API #11121) been asked about several times on issues, discussions, and Slack, so address it directly in the docs
    • previously, it was mentioned only in the 3.5 blog post and nowhere else, so I can understand some of the confusion as the blog is a bit of a secondary resource that is not the easiest to search either

Modifications

  • add a section in the 3.5 upgrading notes about this

    • explicitly say that it is not breaking as the API was not removed
      • (although one could say it is "UI breaking")

  • also add a small mention about it in the UI's new version modal

Verification

Docs and UI builds pass

@agilgur5
docs: add Archived Workflows merge to the Upgrading Notes
3a17f2b 
- it's been asked about several times on issues, discussions, and Slack, so address it directly in the docs
  - previously, it was mentioned in the blog post, but nowhere else, so I can understand some of the confusion

- also add a small mention about it in the UI's new version modal

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs prioritized-review For members of the Sustainability Effort labels Jul 21, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Jul 21, 2024
Joibel
Joibel approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible thing to call out.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2024
@Joibel Joibel merged commit b052452 into argoproj:main Jul 22, 2024
19 checks passed
@agilgur5 agilgur5 deleted the docs-note-archived-workflows-merge branch July 22, 2024 13:43
agilgur5 added a commit that referenced this pull request Jul 25, 2024
@agilgur5
docs: add Archived Workflows merge to the Upgrading Notes (#13371)
4304905 
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit b052452)
@agilgur5 agilgur5 mentioned this pull request Sep 5, 2024
Closed
4 tasks
@agilgur5 agilgur5 mentioned this pull request Oct 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joibel Joibel Joibel approved these changes

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees
No one assigned
Labels
area/docs Incorrect, missing, or mistakes in docs lgtm This PR has been approved by a maintainer prioritized-review For members of the Sustainability Effort
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.
2 participants
@agilgur5 @Joibel