fix: use argocli image from PR in CI + revert #12736 #13018
Conversation
Signed-off-by: Alan Clucas <[email protected]>
…Fixes argoproj#12025 (argoproj#12736)" This reverts commit f1ab5aa. Signed-off-by: Alan Clucas <[email protected]>
Joibel
changed the title
Joibel
added
area/build
|
When I looked into this issue, the CLI was calling ListWorkflows, however ListWorkflows was returning an empty list. |
That may add up to my comment in #12736 (comment) |
There was a problem hiding this comment.
I think the CI changes can be optimized.
Also, I would've personally taken a more targeted approach to fixing this than a full revert (which is going to make the history a lot messier on top of other things); there's only a handful of lines from #12736 that affect non-Server CLI commands
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| return ctx, &argoKubeClient{instanceIDService, wfClient, wfStore}, nil |
There was a problem hiding this comment.
per #12736 (comment), I suspect this is the erroring block
agilgur5
changed the title
agilgur5
changed the title
Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Anton Gilgur <[email protected]> (cherry picked from commit 2f15709)
|
Backported to
|
Fix for CI
This PR fixes CI. It is in two commits, and best read as such
The argocli image is now built and injected into k3d in CI. All uses of it and argoexec in CI are modified to have
imagePullPolicy: Neverto fail if they're not using it. (This is not ideal, we should use a different image and or tag to avoid accidents in future). All uses are now prefixed withquay.ioas that's the name we generate.The revert of #12736 fixes CI, without the revert it still fails (locally). Even with the revert but without building argocli and pushing it into k3d it will fail. Once argocli is built and pushed test-executor passes.