feat: Unified workflows list UI and API

[terrytangyuan]

Fixes #10781.

[terrytangyuan]

For workflow deletion, we need to delete workflow in K8s cluster and in the DB. Here's what I propose we should do:

1. When deleting a workflow, we always delete the workflow in the K8s cluster.
2. In addition, there's a popup in the UI (when clicking the delete button) where the user can select whether to delete the workflow in the DB.

For the backend, we can choose either of the following:

1. Keep the existing behavior of workflowServer.DeleteWorkflow() and UI should call both workflowServer.DeleteWorkflow() and archivedWorkflowServer.DeleteWorkflow().
2. Add an argument deleteArchived bool to workflowServer.DeleteWorkflow(). If deleteArchived=true, workflowServer.DeleteWorkflow() will also call archivedWorkflowServer.DeleteWorkflow() under the hood.

Any thoughts? @jessesuen @sarabala1979

[terrytangyuan]

There should also be a setting (e.g. environment variable) to enable/disable the popup.

[sarabala1979]

we need to delete workflow in K8s cluster and in the DB

For workflow deletion, we need to delete workflow in K8s cluster and in the DB. Here's what I propose we should do:

1. When deleting a workflow, we always delete the workflow in the K8s cluster.
2. In addition, there's a popup in the UI (when clicking the delete button) where the user can select whether to delete the workflow in the DB.

For the backend, we can choose either of the following:

1. Keep the existing behavior of workflowServer.DeleteWorkflow() and UI should call both workflowServer.DeleteWorkflow() and archivedWorkflowServer.DeleteWorkflow().
2. Add an argument deleteArchived bool to workflowServer.DeleteWorkflow(). If deleteArchived=true, workflowServer.DeleteWorkflow() will also call archivedWorkflowServer.DeleteWorkflow() under the hood.

Any thoughts? @jessesuen @sarabala1979

I like it.
if the workflow is in both. a popup will show the checkboxdo you want to delete in the archive

if the workflow is in one place(either k8s/DB), just delete it

Are you going to show the icon in the workflow list archived?

[terrytangyuan]

Discussed with Bala, for the backend we'll use this approach:

Keep the existing behavior of workflowServer.DeleteWorkflow() and UI should call both workflowServer.DeleteWorkflow() and archivedWorkflowServer.DeleteWorkflow().

Are you going to show the icon in the workflow list archived?

Right now it's text "true/false" in the column. The icon doesn't look good in the column and the meaning of the icon is not intuitive.

[rbreeze]

LGTM! Agree with you that global var UI solution isn't ideal, but for now works and shouldn't have side effects.

[agilgur5]

Added some back-links to fixes for issues here for posterity

[agilgur5]

this appears to cause a subtle regression for logs for Workflows that are both live and archived (e.g. ones that have not TTL'd yet): #12948 (comment)