feat(ui): Resubmit workflows with parameters. Fixes #4662

[toyamagu-2021]

Signed-off-by: [email protected] [email protected]

Fixes #4662

Motivation

• We can change parameters when submitting [archived] workflows.

Modifications

• Popup side panel to change parameters when we click resubmit button in [archived] workflows details page.

Verification

To check regression

manifest

spec:
  templates:
    - name: main
      inputs: {}
      outputs: {}
      metadata: {}
      dag:
        tasks:
          - name: step-a
            template: step-template-a
            arguments:
              parameters:
                - name: template-param-1
                  value: '1'
                - name: template-param-2
                  value: 'yes'
                  enum:
                    - 'yes'
                    - 'no'
          - name: step-b
            template: step-template-b
            arguments: {}
    - name: step-template-a
      inputs:
        parameters:
          - name: template-param-1
          - name: template-param-2
            enum:
              - 'yes'
              - 'no'
      outputs: {}
      metadata: {}
      script:
        name: ''
        image: alpine
        command:
          - /bin/sh
        resources: {}
        source: |
          echo "{{inputs.parameters.template-param-1}}"
          echo "{{inputs.parameters.template-param-2}}"
    - name: step-template-b
      inputs:
        parameters:
          - name: workflow-param-1
            value: '{{workflow.parameters.workflow-param-1}}'
          - name: workflow-param-2
            value: '{{workflow.parameters.workflow-param-2}}'
      outputs: {}
      metadata: {}
      container:
        name: main
        image: argoproj/argosay:v2
        command:
          - /argosay
        args:
          - echo
          - >-
            {{inputs.parameters.workflow-param-1}}-{{inputs.parameters.workflow-param-2}}
        resources: {}
  entrypoint: main
  arguments:
    parameters:
      - name: workflow-param-2
      - name: workflow-param-1
        value: 'yes'
        enum:
          - 'yes'
          - 'no'

Submit workflows

• 
• 
• 

Submit workflows from workflow templates select entrypoint

• 
• 

Check to resubmit workflow

manifest

Resubmit to success

• before
  
• resubmit
  
• after
  

Resubmit to fail

• before:
  
• resubmit
  
• after
  

Resubmit to success with memoized

• before
  
• resubmit
  
• after
  

Resubmit archived workflow

• before (Note that Pending status means workflow is deleted by GC)
  
• resubmit
  
• after
  

[toyamagu-2021]

Flaky tests are failing, but I'd like to get community feedback before making these successes.

[terrytangyuan]

I am working on #11121 so this should be implemented in workflows detail/list page once that's merged.

[toyamagu-2021]

Fair enough!
I' will rebase these changes after your PR is merged.

[terrytangyuan]

#11121 has been merged

[toyamagu-2021]

We can use an endpoint for Archived workflows here, but I think not necessary.

https://github.com/toyamagu-2021/argo-workflows/blob/df85d398af7596f99fcfcfe53688e5edbf1d2f79/server/workflow/workflow_server.go#L634

[terrytangyuan]

Could you check if this works for archived workflow as well?

[toyamagu-2021]

This works basically (please see PR description), but I noticed an edge case where this logic will not work because there is more than one workflow that has the same name and namespace.
Could you comment on this issue #11371?

[terrytangyuan]

This one looks good. We can discuss remaining issue separately.