-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add basic support for git tag path prefixes #20948
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment stop on Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
This comment has been minimized.
This comment has been minimized.
I want to improve this PR to move the constraints to the left side of the targetRevision string and support multiple constraints. Standby... |
Please, sign off your commits. |
9fa631c
to
9f91262
Compare
I signed my commits and added a mention of this functionality in the docs under tracking strategies: use cases. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20948 +/- ##
==========================================
- Coverage 55.03% 54.99% -0.05%
==========================================
Files 324 324
Lines 55466 55477 +11
==========================================
- Hits 30526 30508 -18
- Misses 22330 22352 +22
- Partials 2610 2617 +7 ☔ View full report in Codecov by Sentry. |
2c899c4
to
bd9059a
Compare
Signed-off-by: Cameron Harrell <[email protected]>
Signed-off-by: Cameron Harrell <[email protected]>
Signed-off-by: Cameron Harrell <[email protected]>
bd9059a
to
8f454fb
Compare
TL;DR This PR changes the resolveSemverRevision() function to tolerate a path prefix before the semantic version.
This change is useful for teams that:
Closes #20949
Checklist: