New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge E2E argocd-agent 'test/e2e' and 'tests/e2e2' folder into a single test/e2e folder #224

Open

jgwest opened this issue Nov 18, 2024 · 0 comments

Labels

good first issue kind/task refactor

Member

jgwest commented Nov 18, 2024

At present, we have both:

'test/e2e' containing a small number of mock tests that do not require a cluster
'test/e2e2' containing a larger number of tests which DO require a cluster.

As previously discussed, we feel these can be merged together into a 'test/e2e', since they are similar enough to be worth combining.

Criteria:

From our testing, it appears these tests may not currently be working: 'test/e2e/e2e_test.go'. We should get them working again, first.
Next, move this test into 'test/e2e2', and make sure it continues to work (as well as the existing e2e2 tests)
Rename 'tests/e2e2' to 'test/e2e', and update Makefiles and shell scripts as needed
Ensure that everything now works when run via PR checks.

jgwest added good first issue refactor labels

jannfis added the kind/task label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment