From 0ec4b461eaab4f7cbaec56f451f6cc43480d1d4d Mon Sep 17 00:00:00 2001 From: Francisco Aranda Date: Wed, 1 May 2024 12:12:47 +0200 Subject: [PATCH 1/4] wait for argilla-quickstart start --- .github/workflows/integration-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index aa9acb4..af1d1f6 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -19,6 +19,9 @@ jobs: run: shell: bash -l {0} steps: + - name: Wait for argilla-quickstart to start + run: | + while ! nc -z localhost 6900; do sleep 1; done - name: Curl run: curl http://127.0.0.1:6900/api/docs # - name: Checkout Code 🛎 From 38d91032226d37b16bea84578b7138db214e9c4a Mon Sep 17 00:00:00 2001 From: Francisco Aranda Date: Wed, 1 May 2024 14:58:43 +0200 Subject: [PATCH 2/4] Update integration-tests.yml --- .github/workflows/integration-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index af1d1f6..9225ce5 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -21,9 +21,9 @@ jobs: steps: - name: Wait for argilla-quickstart to start run: | - while ! nc -z localhost 6900; do sleep 1; done + while ! curl http://localhost:6900/api/_status; do sleep 1; done - name: Curl - run: curl http://127.0.0.1:6900/api/docs + run: curl -XGET http://localhost:6900/api/docs # - name: Checkout Code 🛎 # uses: actions/checkout@v3 # - name: Setup Conda Env 🐍 From e5ec412a0ed0e145102ac82fba0d47cbde4594c5 Mon Sep 17 00:00:00 2001 From: Francisco Aranda Date: Wed, 1 May 2024 17:07:32 +0200 Subject: [PATCH 3/4] Apply suggestions from code review --- .github/workflows/integration-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 9225ce5..a8709d2 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -21,9 +21,9 @@ jobs: steps: - name: Wait for argilla-quickstart to start run: | - while ! curl http://localhost:6900/api/_status; do sleep 1; done + while ! curl -XGET http://localhost:6900/api/_status; do sleep 1; done - name: Curl - run: curl -XGET http://localhost:6900/api/docs + run: curl -XGET http://localhost:6900/api/_status # - name: Checkout Code 🛎 # uses: actions/checkout@v3 # - name: Setup Conda Env 🐍 From 505927e33f671a9b28a2c6aaa5faf650573e6726 Mon Sep 17 00:00:00 2001 From: Francisco Aranda Date: Wed, 1 May 2024 17:12:59 +0200 Subject: [PATCH 4/4] Update integration-tests.yml --- .github/workflows/integration-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index a8709d2..41160f5 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -12,7 +12,6 @@ jobs: services: argilla: image: argilla/argilla-quickstart:latest - options: --user root ports: - 6900:6900 defaults: