generated from Sceat/app-starter
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/physics #164
Merged
Merged
Feat/physics #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nice, characters movement are good! Only problem i'd see is some camera jitters Screen.Recording.2024-11-18.at.02.36.04.mov |
Sceat
previously approved these changes
Nov 18, 2024
Customize the "camera_control" npm plugin instead of doing things manually
Which was due to the camera target moving vertically when the camera was super close to the player
Sceat
approved these changes
Nov 18, 2024
/merge |
Success! Fast forwarded master to feat/physics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the player physics so that:
it remains stable even under low FPS (the player no longer enters the ground)
it takes into account the voxels and not the heightmap, which means all objects are "hard" (trees for instance)