Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BunnyMock::Channel does not support acknowledge method #18

Open
TimothyMDean opened this issue May 18, 2016 · 3 comments
Open

BunnyMock::Channel does not support acknowledge method #18

TimothyMDean opened this issue May 18, 2016 · 3 comments

Comments

@TimothyMDean
Copy link
Contributor

I have Bunny code that does manual acknowledgement of messages by passing manual_ack: true into the pop method of the Queue class. This allows the message to be redelivered if the consumer class fails to completely process the message.

To make this work, my code must manually acknowledge successful completion of message processing. It does this using the Channel class's acknowledge or ack method. That method is not currently implemented in the BunnyMock::Channel class.

Is is possible to add some sort of rudimentary mocking support for message acknowledgement methods?

@arempe93
Copy link
Owner

If you have an idea of how to make this work, you can submit a PR for it. Or you could explain what needs to happen with regards to acks, nacks, and delivery tags if you have experience with them. Might improve turn around time from me trying to read through the docs :)

@TimothyMDean
Copy link
Contributor Author

I will take a look when I get a chance to see what I can come up with.

@baelter
Copy link
Contributor

baelter commented Jun 13, 2016

Added a stub for it in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants