-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiServer operator bool #345
Open
JAndrassy
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
JAndrassy:server_op_bool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ bf5a079
Click for full report table
Click for full report CSV
|
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Sep 22, 2023
JAndrassy
force-pushed
the
server_op_bool
branch
2 times, most recently
from
September 24, 2023 13:45
aae7a67
to
bf7177e
Compare
Memory usage change @ bf7177e
Click for full report table
Click for full report CSV
|
JAndrassy
force-pushed
the
server_op_bool
branch
from
October 5, 2023 17:56
bf7177e
to
e05cae1
Compare
JAndrassy
force-pushed
the
server_op_bool
branch
from
October 5, 2023 18:06
e05cae1
to
227c3f7
Compare
Memory usage change @ 227c3f7
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other WiFi libraries it is a problem to implement proper server.status(), but easy to implement operator bool.
Even WiFi101 has status(), it always just returns 0.
overview of Server implementations in libraries https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#server-class