Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throttling to frontend api calls #162

Open
ajaythapliyal opened this issue Mar 8, 2023 · 11 comments
Open

Add throttling to frontend api calls #162

ajaythapliyal opened this issue Mar 8, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@ajaythapliyal
Copy link
Collaborator

No description provided.

@abdulriiyaz
Copy link

abdulriiyaz commented Jun 23, 2023

Could you please provide a brief question related to adding throttling to frontend API call?

We can always use throttle-debounce.

I'm open to contribute to this amazing project!

@dartpain dartpain added good first issue Good for newcomers javascript Pull requests that update Javascript code labels Sep 28, 2023
@codingmickey
Copy link

codingmickey commented Oct 2, 2023

Heyy, I would like to get this thing done!! @dartpain Can you assign it to me as there wasn't any active response from the last guy :(

@dartpain
Copy link
Contributor

dartpain commented Oct 2, 2023

yep, assigning, thank you!

@dartpain dartpain assigned codingmickey and unassigned abdulriiyaz Oct 2, 2023
@gauravdhiman217
Copy link

@codingmickey Hey there, are you still working on it. @dartpain if no-one is working on it i will love to contribute.

@codingmickey
Copy link

codingmickey commented Oct 9, 2023 via email

@dartpain
Copy link
Contributor

dartpain commented Nov 3, 2023

Hi @codingmickey How is the progress?

Thank you!

@abdulriiyaz
Copy link

@gauravdhiman217 you can, im marking.

@surajTade
Copy link

@ajaythapliyal / @dartpain
I noticed that this issue is still open. Can I work on it? Are there any specific requirements regarding throttling, such as the time interval between requests? Should I use a particular library, or would you prefer that I develop an in-house throttler?

@dartpain dartpain assigned surajTade and unassigned codingmickey Oct 6, 2024
@surajTade
Copy link

surajTade commented Oct 7, 2024

@dartpain
Few questions before I start coding:

  1. Should I implement the throttling at the service layer (/frontend/src/api/client.ts) or at specific locations where the service is being used?
  2. Do we want a custom throttling logic, or we can use an external dependency?

@siiddhantt
Copy link
Collaborator

hi @surajTade , thanks for your interest in working on this issue.
Yes please implement the throttling at the service layer and you're welcome to use an external dependency for simplicity and reliability as long as they are light.

@surajTade
Copy link

hii @siiddhantt
can you be more specific about what all needs to be implemented here? I understand that the backend should not get overwhelmed with the number of requests, but "Add throttling seems to be very superficial.

I tried implementing this throttling logic with limit, although I'm not sure if this is what was expected as per the request.
please review and let me know if something needs to be changed: #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
Status: Backlog
Development

No branches or pull requests

7 participants