Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Attachment source doc #1036

Open
1 task done
laronson opened this issue Jul 15, 2024 · 4 comments · May be fixed by #1037
Open
1 task done

🚀 Feature: Attachment source doc #1036

laronson opened this issue Jul 15, 2024 · 4 comments · May be fixed by #1037

Comments

@laronson
Copy link

laronson commented Jul 15, 2024

🔖 Feature description

Give users a method of selecting source documents that is integrated into the query writing process. To do this, add a hotkey to the input text box which opens a selection popup and allows users to select from a list of their available source documents. Once an option is selected, display the selection above the input text box to give users better insight into which documents they are using for their query.

doc_selection_demo.mov

🎤 Why is this feature needed ?

This feature provides a few benefits to the user:

  • The hot key doc selection mechanism may enhance the query writing workflow for some users as it allows user focus to remain closer to the input text box without needing to shift focus to the source docs dropdown on the left side of the page.
  • Highlighting the document that is being used for the current query closer to the input text box may reduce confusion for some users as to which document is selected for use with their current query.
  • This new selection mechanism could be used in the future to scale the number of document included in a search when/if the project moves to allow more than one document to be used in a single query.

✌️ How do you aim to achieve this?

  1. Add a popup selector to the project as a common component to use for document selection outside of the source docs dropdown.
  2. Add a source document pill list on top of the conversation input text box to show the user which document is selected for the query they are writing
  3. Refactor the conversation input text box to use the new popup selector and pill list components.
  • For a proposed hot key, I think ctrl + d could be a good selection.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@dartpain dartpain linked a pull request Jul 15, 2024 that will close this issue
@dartpain dartpain changed the title 🚀 Feature: 🚀 Feature: Attachment source doc Jul 19, 2024
@sOnU1002
Copy link

sOnU1002 commented Oct 2, 2024

i can do it please assign tis to me

@dartpain
Copy link
Contributor

dartpain commented Oct 4, 2024

This issue, I really cool. We will probably do a heavy redesign in terms of sources.
Really appreciate you idea @laronson
Once we come up with a cool design idea for it we can continue working on it.

@laronson
Copy link
Author

laronson commented Oct 4, 2024

@sOnU1002 @dartpain

Thanks for the shoutout! I would love to help get this going when you find time. I have an open PR with some changes to help with this. I know you have been working on change to the UI over the last few months but I would be happy to refactor my PR with those new changes if this were something that you wanted to integrate into the project.

@dartpain
Copy link
Contributor

dartpain commented Oct 5, 2024

We are still making some other UI/UX changes that are more of a decided matter.
But I will keep you updated! think @tenokami might come up with some cool ideas soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants