Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate csaf-poc/csaf_distribution to gocsaf/csaf #7805

Closed
knqyf263 opened this issue Oct 29, 2024 Discussed in #7804 · 8 comments · Fixed by #7992
Closed

Migrate csaf-poc/csaf_distribution to gocsaf/csaf #7805

knqyf263 opened this issue Oct 29, 2024 Discussed in #7804 · 8 comments · Fixed by #7992
Assignees
@thiha-min-thant
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@knqyf263
Copy link
Collaborator

Description

csaf-poc/csaf_distribution has been moved to https://github.com/gocsaf/csaf. Our go.mod should be updated.

trivy/go.mod

Line 45 in 63dd3d6

github.com/csaf-poc/csaf_distribution/v3 v3.0.0

Discussed in #7804
@knqyf263 knqyf263 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 29, 2024
@thiha-min-thant
Copy link
Contributor

Hi @knqyf263 , could you please assign to me?

@knqyf263
Copy link
Collaborator Author

Sure

@thiha-min-thant
Copy link
Contributor

Hi @knqyf263 , I'm currently blocked and unable to proceed, pending a response on this thread: gocsaf/csaf#580. Thank you!

@knqyf263
Copy link
Collaborator Author

I think they need to update go.mod.
https://github.com/gocsaf/csaf/blob/f7dc3f5ec74ea8ccada62f64a15cd9d6f9fd8b72/go.mod#L1

@thiha-min-thant
Copy link
Contributor

Update Pending: The related changes will be applied once PR #585 is merged.

@abhay-krishna
Copy link

abhay-krishna commented Nov 6, 2024 •
edited
Loading

@thiha-min-thant It looks like gocsaf/csaf#585 has merged. Is there a tentative timeline on when Trivy will migrate to the new repo?

@abhay-krishna abhay-krishna mentioned this issue Nov 6, 2024
Open
@thiha-min-thant
Copy link
Contributor

Hi @abhay-krishna , It seems like we’ll need to hold off until gocsaf/csaf#579 is resolved.
Screenshot 2024-11-06 at 1 02 57 PM

@abhay-krishna
Copy link

Ah gotcha! Thanks for the response, will be on the lookout for that to get resolved.

@thiha-min-thant thiha-min-thant mentioned this issue Nov 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiha-min-thant thiha-min-thant

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update csaf module dependency from csaf-poc to gocsaf thiha-min-thant/trivy
4 participants
@knqyf263 @thiha-min-thant @abhay-krishna and others