Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_root_zone_water being called inside functions #35

Open
thomasdkelly opened this issue Feb 7, 2022 · 0 comments
Open

_root_zone_water being called inside functions #35

thomasdkelly opened this issue Feb 7, 2022 · 0 comments
Labels
code structure changes to code structure, data containers, function arguments speed/efficiency improvements to simulation run time

Comments

@thomasdkelly
Copy link
Collaborator

Through the line_profile test we can see a good chunk of time is being spend in the transpiration, canopy_cover, harvest index functions. These functions all call inner functions such as _root_zone_water which prevents us from AOT compiling them (#33 ). From a quick glance it appears as though _root_zone_water could instead be called just before these functions are called, with the _root_zone_water return arguments then being passed on to the transpiration/canopy cover function.

@thomasdkelly thomasdkelly added speed/efficiency improvements to simulation run time code structure changes to code structure, data containers, function arguments labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code structure changes to code structure, data containers, function arguments speed/efficiency improvements to simulation run time
Projects
None yet
Development

No branches or pull requests

1 participant