Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic APPUiO Managed OpenShift 4 architecture page #293

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Add generic APPUiO Managed OpenShift 4 architecture page #293

merged 4 commits into from
Dec 1, 2023

Conversation

simu
Copy link
Member

@simu simu commented Nov 22, 2023

No description provided.

@simu simu force-pushed the ocp4-architecture branch 4 times, most recently from a51459a to e009b96 Compare November 27, 2023 13:49
@simu simu force-pushed the ocp4-architecture branch from e009b96 to d262cc9 Compare November 27, 2023 14:40
@simu simu marked this pull request as ready for review November 27, 2023 15:48
@simu simu requested review from corvus-ch and a team November 27, 2023 15:49
corvus-ch
corvus-ch suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add:

  • an introductory text with links to further reading sources.
  • a perspective of who needs to access what on the cluster and their network context they are cumming from (especially VSHN).

docs/modules/ROOT/pages/references/architecture/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/references/architecture/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/assets/images/ocp4-external-dependencies.svg Outdated Show resolved Hide resolved
docs/modules/ROOT/assets/images/ocp4-architecture.svg Outdated Show resolved Hide resolved
@simu
Restructure generic architecture
330635d 
* Add better intro
* Improve structure
* Add links to OCP/K8s architecture docs
@simu simu force-pushed the ocp4-architecture branch from b1ed306 to 330635d Compare November 29, 2023 09:25
@simu simu requested a review from corvus-ch November 29, 2023 12:24
corvus-ch
corvus-ch approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@corvus-ch corvus-ch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/modules/ROOT/pages/references/architecture/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/references/architecture/index.adoc Show resolved Hide resolved
@HappyTetrahedron HappyTetrahedron merged commit 85d9ebf into master Dec 1, 2023
1 check passed
@HappyTetrahedron HappyTetrahedron deleted the ocp4-architecture branch December 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corvus-ch corvus-ch corvus-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simu @corvus-ch @HappyTetrahedron