Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Capistrano deploy method #781

Open
1 of 2 tasks
tombruijn opened this issue Dec 13, 2021 · 0 comments
Open
1 of 2 tasks

Deprecate Capistrano deploy method #781

tombruijn opened this issue Dec 13, 2021 · 0 comments
Labels

Comments

@tombruijn
Copy link
Member

tombruijn commented Dec 13, 2021

It's using the underlying "notify_of_deploy" behavior, and we should recommend the "revision" config option instead.

We've already deprecated the notify_of_deploy CLI tool: https://docs.appsignal.com/ruby/command-line/notify_of_deploy.html
Read the deploy markers page for more context: https://docs.appsignal.com/application/markers/deploy-markers.html

Part of https://github.com/appsignal/integration-guide/issues/111

Issue affected by this decision: #323

To do

  • Print deprecation warning on usage of Capistrano 2 & 3 integrations. Their only purpose should be to send the "notify of deploy" request. And if so, print a deprecation warning when it does so.
  • Update Capistrano docs to mention the appsignal_revision option is deprecated. Done in commit e4ac141.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant