Fix regresson in obok on certain win10 machines #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed MAC address fetching code to address possibile regression
|
This patch fixed an issue I was having where the command line obok would be sucessful, but the plugin version reported success but resulted in importing an encrypted epub file. Please merge! (Fixes #1718 as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim to fix the problem reported in issue #1673
As that problem presents using the new implementation for __getmacaddrs on certain machines (fails the key fetch without raising any error), while the old implementation thows an exception in output line parsing conversion.
The fix uses by default the 7.1.0 implementation, wrapping it in a try-except block and using the 7.2.1 impl only when the old impl fails.