Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic rollback #43

Open
JohnMurray opened this issue Mar 3, 2015 · 0 comments
Open

automatic rollback #43

JohnMurray opened this issue Mar 3, 2015 · 0 comments
Labels

Comments

@JohnMurray
Copy link
Contributor

While running an alter, when encountering failure, we do one of two things:

  1. output the error and stop running up alters
  2. output the error and continue running alters, assuming that the -f flag is provided to the command

I am proposing either an alternative behavior for no. 1 or a new behavior (driven by configuration) in which, when we encounter an error we also attempt to do a rollback (running the down alter).

The open question is whether or not this should be done for the -f option or not. An argument could be made either way as to the semantics of the -f option. We might also be able to introduce a new option which ignores rollbacks on a force.

Since -f means "force" I feel the semantics should imply that we drop safety features like automatic rollback and leave it as a "run at your own risk" kind of feature.

@JohnMurray JohnMurray added this to the v0.3.0 milestone Mar 3, 2015
@JohnMurray JohnMurray removed this from the v0.3.0 milestone May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant