カスタムユニットがロード時にアンシリアライズされ、エラーが表示される問題 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uidev1116
reviewed
Nov 28, 2024
src/Models/Entry.php
Outdated
| @@ -154,7 +154,7 @@ public function load($item) | |||
| foreach ($this->units as & $unit) { | |||
| $type = detectUnitTypeSpecifier($unit->getType()); | |||
| if ($type === 'custom') { | |||
| $unit->setField6(acmsUnserialize($unit->getField6())); | |||
| $unit->setField6($unit->getField6()); | |||
| } | |||
There was a problem hiding this comment.
@1000-x-t30
$unit の field6 の値を $unit の field6 で上書きしてるので、setField6 する前と後で何も変わってないということですかね？
となると、そもそも if ($type === 'custom') { ... } まで不要なのでは？と思うのですがどうでしょうか？
There was a problem hiding this comment.
columnテーブルにはフィールド情報もっていないので、翻訳するには専用の処理が必要だと思われます。
There was a problem hiding this comment.
$unit->getCustomUnitField() でフィールドが取得できるのかな。
There was a problem hiding this comment.
@atsu666 @1000-x-t30
$unit->getCustomUnitField() が生えるのは 3.2 からなので、現状はカスタムユニットの翻訳は未対応ということでいいのかなと思ってます。
There was a problem hiding this comment.
@atsu666 @uidev1116
ご指摘ありがとうございます。
現状はカスタムユニットの翻訳未対応で、アンシリアライズする必要がなく内容の変化がないので条件ごと削除しました。
ご確認お願いいたします。
atsu666
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.