Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include privacy manifest on Darwin #257

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Only include privacy manifest on Darwin #257

merged 1 commit into from
Sep 18, 2024

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Sep 17, 2024

Motivation:

The privacy manifest is only required on Darwin. It's currently included on all platforms which results in build warnings.

Modifications:

  • Only include manifest on Darwin
  • Exclude the privacy manifest from the build on other platforms

Result:

@glbrntt
Only include privacy manifest on Darwin
584e79a 
Motivation:

The privacy manifest is only required on Darwin. It's currently included
on all platforms which results in build warnings.

Modifications:

- Only include manifest on Darwin
- Exclude the privacy manifest from the build on other platforms

Result:

- Fewer warnings
- Resolves apple#256
@glbrntt glbrntt requested a review from Lukasa September 17, 2024 13:28
@glbrntt glbrntt added the semver/none No version bump required. label Sep 17, 2024
@Lukasa Lukasa merged commit a24950b into apple:main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to build with Swift 6 on Linux due to PrivacyInfo
2 participants
@glbrntt @Lukasa