Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella: Update Wycheproof test vectors to v1 #165

Closed
15 tasks done
Sajjon opened this issue Apr 4, 2023 · 3 comments
Closed
15 tasks done

Umbrella: Update Wycheproof test vectors to v1 #165

Sajjon opened this issue Apr 4, 2023 · 3 comments

Comments

@Sajjon
Copy link
Contributor

Sajjon commented Apr 4, 2023

This issue is an umbrella issue where we can keep track of my efforts upgrading all Wycheproof test vectors from v0 to v1.

@Sajjon
Copy link
Contributor Author

Sajjon commented Apr 4, 2023

@Lukasa aha! swift-crypto contains four Wycheproof test vectors which are not at all used:

  • ecdh_test.json
  • ecdh_webcrypto_test.json
  • ecdsa_test.json
  • ecdsa_webcrypto_test.json

So I propose we delete them, it is a bit misleading to have them there. And then I can add new tests ECDSA using IEEE P1316 encoding, using ECDSASignature.init:rawRepresentation initialiser for which Wycheproof v1 vendors:

So I propose the four unused vectors gets deleted, and I add a new unit tests, and update ECDSASignatureTests to be shared for current tests and for the P1316 format tests, by accepting a function pointer to an ECDSASignature initializer, using init:derRepresentation for current tests, and using init:rawRepresentation init for the P1316 test vectors, what do you think about that @Lukasa ?

EDIT: done: #167

@Lukasa
Copy link
Contributor

Lukasa commented Apr 11, 2023

Hey @Sajjon, are there any further vectors you'd like to add as part of this ticket?

@Sajjon
Copy link
Contributor Author

Sajjon commented Apr 11, 2023

@Lukasa I think I'm done for now, I will close this issue.

@Sajjon Sajjon closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants