-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sendable conformance to appropriate types #150
Comments
Ah the by Github listed "mention" was a red herring, I was trying to write "amount: 150" using pound sign, which was a silly thing to do, since I forgot GH lists is a references... Sorry for misleading "mention". But YES I agree |
I see no reason for |
Huh, I thought I commented on this. Regardless: we've heard this feedback internally, thanks for providing it! |
@Lukasa mind if I submit a PR making PublicKeys Equatable? I know different topic... but IMO falls under non dangerous protocol conformances helping devs :) |
This is a good suggestion, thanks. As this affects the common API layer between CryptoKit and Swift Crypto, while you can make a PR we will be unable to merge it until an equivalent change ships in CryptoKit. |
Are the people who maintain CryptoKit the same ones who maintain Swift Crypto - or should I post this suggestion somewhere else? |
I'm afraid that's not something I can get into detail about, but I will say that filing a request using Feedback Assistant is always valuable. |
Add
Sendable
conformance to appropriate types would allow to enabled additional safety checks at compile time. Without it, developers have to guess whether a type isSendable
or not.The text was updated successfully, but these errors were encountered: