feat: add appPath to handleCreateSession #230
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebDriverAgentMac/WebDriverAgentLib/Commands/FBSessionCommands.m
Outdated
Show resolved
Hide resolved
WebDriverAgentMac/WebDriverAgentLib/Commands/FBSessionCommands.m
Outdated
Show resolved
Hide resolved
|
@proAlexandr Please sign the CLA |
proAlexandr
force-pushed
the
feat-session-create-app-path
branch
from
a84beb3 to
cd90662
Compare
|
Hi @mykola-mokhnach. Thanks a lot for review! |
proAlexandr
force-pushed
the
feat-session-create-app-path
branch
from
cd90662 to
3f40a05
Compare
mykola-mokhnach
approved these changes
Sep 7, 2023
proAlexandr
force-pushed
the
feat-session-create-app-path
branch
from
5537c4e to
f6400f9
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
## [1.8.0](v1.7.4...v1.8.0) (2023-09-08) ### Features * add appPath to handleCreateSession ([#230](#230)) ([7b7cc17](7b7cc17))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Allows to explicitly specify path to .app application that will be opened by driver.
Context:
During development you can have many build of the same application with the same bundleId on your machine. You have no control which one will be opened by
[[XCUIApplication alloc] initWithBundleIdentifier:bundleID]. So you can end up testing wrong build (for example, production build from /Application folder instead of dev build that includes local changes).This PR introduces appPath argument for /session request to specify a path to .app application and be sure that webdriver launches exactly the same build that you need.