This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: call requirePackage in doctor #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await node.requirePackage(packageName); | ||
| return okOptional(`${packageName} is installed.`); | ||
| } catch (ign) { | ||
| return nokOptional(`${packageName} cannot be found.`); |
There was a problem hiding this comment.
I would still prefer to show the original error here. Some packages just error out after being imported , even though after it looks like they were installed properly (hello opencv4nodejs 👋 )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84
Noticed
getNpmPackageInfodid not work well likerequirePackagein some cases.e.g. global install of
mjpeg-comsumer.Appium uses
requirePackageto resolve a package, so let's use the same method to check if it is installed.I also noticed
packageInfo.versionwas undefined inmjpeg-comsumer, so simply let me show if the package is installed.hm... error appeared twice.