Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smith: use apollo-compiler types #805

Open
lrlna opened this issue Jan 15, 2024 · 0 comments
Open

smith: use apollo-compiler types #805

lrlna opened this issue Jan 15, 2024 · 0 comments
Assignees

Comments

@lrlna
Copy link
Member

lrlna commented Jan 15, 2024

For historical reasons, a lot of the apollo-smith codebase is based on the parser. Now that the compiler is stabilising, we can unify the apollo-compiler and apollo-smith GraphQL representations, instead of having to maintain yet another one. Ideally, each type generation by the DocumentBuilder would output apollo-compiler types, rather than the custom apollo-smith type, e.g. this function here returns an apollo-smith representations that we then maintain separately. This can be ast::Arugment instead.

@BrynCooke BrynCooke changed the title smith: align the library closer to apollo-compiler smith: use apollo-compiler types Jan 29, 2024
@BrynCooke BrynCooke self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants