Makes error handling more consistent #9941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super cool @MrDoomBringer (which is an appropriate GH username for working on error PR's 😂). Let us know when you think this is ready for review (holding off for now since it's still in draft). Thanks! |
MrDoomBringer
changed the title
Mutations basic run ApolloLink Revert "Mutations basic run" This reverts commit b3a130d. Test support Rename error_network -> errorNetwork onError link support bump bundlesize from 29.95 -> 29.98KB Consolidate errorNetwork away
MrDoomBringer
force-pushed
the
error-handling
branch
from
1fb4dbb to
27c85d0
Compare
|
@MrDoomBringer feel free to ping me when the conflicts are resolved and I'll take a look 👍 |
|
Hey @alessbell! I think this PR needs a bit more work, so I'll be putting it on the backburner for now. Definitely some good preliminary work in here through that should be useful when it's time to revisit it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this Issue for more information: #9870
This PR aims to make the
networkErrorandgraphQLErrorsfields on the result object behave as expected for all react hooks - on any 4/500 error codenetworkErrorwill be populated, and if there's any GraphQL error from the server, it will be present in that field.Behavior currently looks good with useQuery, useSubscription, and ApolloLink.
I tried to make the implementation as non-intrusive as possible, both for backwards compatability and to hopefully prevent regressions by touching too much code.
TODO: Add test coverage
Checklist: