Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data masking] Mask data returned from subscriptions #12038

Merged
merged 11 commits into from
Aug 28, 2024
Merged

[Data masking] Mask data returned from subscriptions #12038

merged 11 commits into from
Aug 28, 2024

Conversation

jerelmiller
Copy link
Member

Closes #12024

Masks data returned from subscriptions. This affects a few places:

  • data property returned from useSubscription
  • data passed to the onData callback in useSubscription
  • data property emitted from client.subscribe()

This does not however apply data masking to the subscriptionData property passed to updateQuery for observableQuery.subscribeToMore() as that is used for a cache write.

@jerelmiller jerelmiller added the 🎭 data-masking Issues/PRs related to data masking label Aug 27, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c288798

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the auto-cleanup 🤖 label Aug 28, 2024
@jerelmiller jerelmiller force-pushed the jerel/mask-plain-query branch from e9c8386 to 093a19a Compare August 28, 2024 16:46
Base automatically changed from jerel/mask-plain-query to data-masking August 28, 2024 16:58
@jerelmiller jerelmiller force-pushed the jerel/mask-subscriptions branch from e35c203 to 31f23fc Compare August 28, 2024 16:59
@jerelmiller jerelmiller merged commit b3c607b into data-masking Aug 28, 2024
32 checks passed
@jerelmiller jerelmiller deleted the jerel/mask-subscriptions branch August 28, 2024 17:06
@jerelmiller jerelmiller mentioned this pull request Aug 28, 2024
Closed
jerelmiller added a commit that referenced this pull request Aug 28, 2024
@jerelmiller
[Data masking] Mask data returned from subscriptions (#12038)
8d6ce82
jerelmiller added a commit that referenced this pull request Aug 28, 2024
@jerelmiller
[Data masking] Mask data returned from subscriptions (#12038)
05eb7b8
jerelmiller added a commit that referenced this pull request Sep 24, 2024
@jerelmiller
[Data masking] Mask data returned from subscriptions (#12038)
11142cd
jerelmiller added a commit that referenced this pull request Sep 24, 2024
@jerelmiller
[Data masking] Mask data returned from subscriptions (#12038)
3fcc1b2
jerelmiller added a commit that referenced this pull request Sep 24, 2024
@jerelmiller
[Data masking] Mask data returned from subscriptions (#12038)
d7cc9f2
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phryneas phryneas phryneas approved these changes

@alessbell alessbell Awaiting requested review from alessbell

Assignees
No one assigned
Labels
auto-cleanup 🤖 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerelmiller @phryneas