refetchQueries with explicit list refetches inactive queries in React StrictMode

[levrik]

Issue Description

refetchQueries on useMutation results in inactive queries to be refetched as well if given an explicit list of queries.

As explained over at #11894 (comment) by @jerelmiller, Apollo Client seems to rely on inactive queries to be removed from queryManager.queries for refetchQueries. In StrictMode queries get inserted twice into queryManager.queries and only 1 instance gets removed on unmount of the parent component of useQuery. Since queryManager.getObservableQueries() gets passed an explicit list by queryManager.refetchQueries(), it simply returns all observables for given queries regardless of active/inactive state, resulting in also inactive queries to be refetched.

This is specifically annoying if you have a query like project(id: '...') and expect to only refetch the currently opened project and not all which have been opened in the past.

Link to Reproduction

https://codesandbox.io/p/devbox/recursing-surf-tmwx9d

Reproduction Steps

1. Open DevTools
   You should see resolve `people(filter: undefined)` in logs
2. Click "Dummy Query" link
   You should see resolve `people(filter: dummy)` in logs
3. Click "Home" link
4. Add a name through the form
   You should see resolve `people(filter: undefined)` and resolve `people(filter: dummy)` in logs

@apollo/client version

3.12.3

[triagster]

No dupes found!

[jerelmiller]

@levrik I believe #11914 also describes this same issue which will likely be fixed by #11925.

I'll do by best to take some time this week to rereview PR and see if we can get it in a patch. Please follow progress on that PR for updates.

[levrik]

@jerelmiller Ah, I saw that issue but thought it's different as calling resetStore seemed to be important there which I don't do. Will keep an eye on that PR.