Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect config for data masking for client preset in docs #12218

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Dec 12, 2024

Reported here: https://discord.com/channels/1022972389463687228/1316737355633135636/1316737355633135636

I have tried this myself and can confirm it works as expected.

@jerelmiller jerelmiller requested a review from a team as a code owner December 12, 2024 21:38
@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 12, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/apollo-client@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "apollo-client",
        "branch": "jerel/fix-docs-client-preset"
      }
    }
  }
}
Name Link

Commit

fd9146a

Preview

https://www.apollographql.com/docs/deploy-preview/e5619aa0aa2e3af7cec5

Build ID

e5619aa0aa2e3af7cec5

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/react/(latest)/data/fragments.mdx

Pages

1


1 pages published. Build will be available for 30 days.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: fd9146a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 12, 2024

npm i https://pkg.pr.new/@apollo/client@12218

commit: fd9146a

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit fd9146a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/675b57c32cda260008bee8d9
😎 Deploy Preview https://deploy-preview-12218--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.02 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.14 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.13 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.54 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@jerelmiller jerelmiller merged commit 07907ea into main Dec 12, 2024
46 checks passed
@jerelmiller jerelmiller deleted the jerel/fix-docs-client-preset branch December 12, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants