masking/types.d.ts imports from "./internal/types.ts"

[Yogu]

Issue Description

Starting in @apolllo/[email protected], the file masking/types.d.ts has this import statement:

import type { ContainsFragmentsRefs, IsAny, RemoveFragmentName, RemoveMaskedMarker, UnwrapFragmentRefs } from "./internal/types.ts";

The file types.ts does not exist in the NPM package. The file types.d.ts would exist.

This results in this typescript error

Error: node_modules/@apollo/client/masking/types.d.ts:2:111 - error TS2691: An import path cannot end with a '.ts' extension. Consider importing './internal/types.js' instead.

2 import type { ContainsFragmentsRefs, IsAny, RemoveFragmentName, RemoveMaskedMarker, UnwrapFragmentRefs } from "./internal/types.ts";
                                                                                                                ~~~~~~~~~~~~~~~~~~~~~

The fix is probably to change this line to import from .js instead of .ts.

Link to Reproduction

Let me know if you need this

Reproduction Steps

No response

@apollo/client version

3.12.0

[phryneas]

Hi @Yogu,
that's a great catch!

Could you try the CI build from #12171 to see if it fixes the problem?

npm i https://pkg.pr.new/@apollo/client@12171

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[jerelmiller]

We just released 3.12.1 which should fix this. Thanks for raising the issue!

[Yogu]

That was quick, thank you! I just tested 3.12.1 and it seems to fix the issue.