Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing utilities] Call createMockSchema from within createTestSchema #11776

Closed
alessbell opened this issue Apr 10, 2024 · 3 comments · Fixed by #11777
Closed

[Testing utilities] Call createMockSchema from within createTestSchema #11776

alessbell opened this issue Apr 10, 2024 · 3 comments · Fixed by #11777
Assignees
@alessbell
Milestone
Schema-driven tes...

Comments

@alessbell
Copy link
Contributor

Issue Description

Instead of having users call createMockSchema and pass the resulting schema to createTestSchema, let's perform this extra step in createTestSchema itself.

Link to Reproduction

N/A

Reproduction Steps

No response

@apollo/client version

N/A
@alessbell alessbell added this to the Schema-driven testing milestone Apr 10, 2024
@alessbell alessbell self-assigned this Apr 10, 2024
@alessbell alessbell mentioned this issue Apr 10, 2024
Merged
@alessbell alessbell linked a pull request Apr 12, 2024 that will close this issue
Call createMockSchema inside createTestSchema #11777
Merged
@alessbell
Copy link
Contributor Author

Completed via #11777

@github-actions GitHub Actions
Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alessbell alessbell

Labels
None yet
Projects
None yet
Milestone
Schema-driven testing
Development

Successfully merging a pull request may close this issue.

Call createMockSchema inside createTestSchema apollographql/apollo-client
1 participant
@alessbell