Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improperly escaped error arguments for go.apollo.dev links #11572

Closed
david-morris opened this issue Feb 5, 2024 · 4 comments
Closed

improperly escaped error arguments for go.apollo.dev links #11572

david-morris opened this issue Feb 5, 2024 · 4 comments
Labels
🔍 investigate Investigate further ℹ needs-more-info Needs more information to determine root cause

Comments

@david-morris
Copy link

david-morris commented Feb 5, 2024

Issue Description

Error links are not formatting correctly for me.

When I follow links from files which have had console output written to them, it looks like this:
image

When I follow the link directly on the command line, there appear to be arguments missing:
image

Here's how it looks in browser:
image

Link to Reproduction

https://go.apollo.dev/c/err#%7B%22version%22%3A%223.8.1%22%2C%22message%22%3A10%2C%22args%22%3A%5B%5D%7D, towerClusters, {"__typename":"WindTurbine","id":"turb-20002","capacity":1000,"defaultHubHeight":70,"defaultTowerType":"STEEL","defaultFoundationType":1,"defaultGearType":1,"pk":"20002","name":"AK-12","rotorDiameter":91,"manufacturer":{"id":"Manu-1","name":"Nordex","__typename":"WindTurbineManufacturer"}}

Reproduction Steps

check out this apollo go address:

https://go.apollo.dev/c/err#%7B%22version%22%3A%223.8.1%22%2C%22message%22%3A10%2C%22args%22%3A%5B%5D%7D, towerClusters, {"__typename":"WindTurbine","id":"turb-20002","capacity":1000,"defaultHubHeight":70,"defaultTowerType":"STEEL","defaultFoundationType":1,"defaultGearType":1,"pk":"20002","name":"AK-12","rotorDiameter":91,"manufacturer":{"id":"Manu-1","name":"Nordex","__typename":"WindTurbineManufacturer"}}

https://go.apollo.dev/c/err#%7B%22version%22%3A%223.8.1%22%2C%22message%22%3A10%2C%22args%22%3A%5B%5D%7D, towerClusters, {"__typename":"WindTurbine","id":"turb-20002","capacity":1000,"defaultHubHeight":70,"defaultTowerType":"STEEL","defaultFoundationType":1,"defaultGearType":1,"pk":"20002","name":"AK-12","rotorDiameter":91,"manufacturer":{"id":"Manu-1","name":"Nordex","__typename":"WindTurbineManufacturer"}}

Clearly there's something that's not escaped properly, potentially a space.

@apollo/client version

3.8.1

@jerelmiller
Copy link
Member

Hey @david-morris 👋

Would you try upgrading to version >= 3.8.4? That release contained #11195 which fixed some serialization issues with errors that may also fix this one. Thanks!

@jerelmiller jerelmiller added 🔍 investigate Investigate further ℹ needs-more-info Needs more information to determine root cause labels Feb 5, 2024
@david-morris
Copy link
Author

Hey @david-morris 👋

Would you try upgrading to version >= 3.8.4? That release contained #11195 which fixed some serialization issues with errors that may also fix this one. Thanks!

Thanks for that info! We have a PR already to update to 3.8.10 and I can confirm that this is fixed by then.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔍 investigate Investigate further ℹ needs-more-info Needs more information to determine root cause
Projects
None yet
Development

No branches or pull requests

2 participants