Proposal for an Option to Enable Infinite Reuse of Mocks

[leekib]

I think it would be great to add a clear option for continuous reuse of mocks

I saw that the maxUsageCount option was added for mock reuse in #11178.
I've been using mockLink with MockedResponses defined with a reasonably large number for maxUsageCount for development mock APIs, but I would love to see an option added for infinite reuse.
I read the comment in #9738 about the introduction of a new testing method using schemaLink. However, I think it would be great to add a clear option for continuous reuse of mocks in the existing MockedProvider method before that.
For example, while maintaining the current behavior when no maxUsageCount is provided, we could change the type of maxUsageCount to number | 'infinite' to allow specifying infinite explicitly for infinite reuse of mocks.
Would this approach be acceptable?

import { MockedResponse } from "@apollo/client/testing";

const dogMock: MockedResponse<Data, Variables> = {
  request: {
    query: GET_DOG_QUERY
  },
  variableMatcher: (variables) => true,
  //maxUsageCount: 9999, 
  maxUsageCount: 'infinite',
  result: {
    data: { dog: { id: 1, name: 'Buck', breed: 'poodle' } },
  },
};

[jerelmiller]

Hey @2012160085 👋

maxUsageCount already handles Number.POSITIVE_INFINITY as a valid value. Per our docs

Passing Number.POSITIVE_INFINITY will cause the mock to be reused indefinitely.

In fact, we have a test case for this to prove this works.

Does this address what you're looking for?

Edit: Adding that maxUsageCount was added in 3.9.0 which was released 2 days ago on Jan 30th 🙂

[leekib]

Thanks for fast response. I didnt think of Number.POSITIVE_INFINITY.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[jerelmiller]

You're welcome! Glad that works for you!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.